[AUTOMATION] fix: optimize internal/guard/policy evaluation category checks#241
Open
michiosw wants to merge 1 commit into
Open
[AUTOMATION] fix: optimize internal/guard/policy evaluation category checks#241michiosw wants to merge 1 commit into
michiosw wants to merge 1 commit into
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Greptile SummaryThis PR optimizes deterministic guard policy evaluation by reusing the enabled category set. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(policy): reuse enabled category map ..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This optimizes deterministic policy evaluation by reusing the enabled category set for the full rule pass.
Before this,
internal/guard/policy/engine.gorebuilt the same profile category map for every rule check, which added repeated allocations on every hook decision.Now one enabled-category map is built once per evaluation and reused across the rule loop.
Why
This gives kontext-cli a cheaper runtime path for deterministic guard policy decisions:
hook event
->
internal/guard/policy.Engine.Evaluate-> one profile category map + rule matching result
This PR does not broaden behavior beyond the optimization scope.
What changed
Optimized deterministic policy category checks in
internal/guard/policy/engine.goRemoved repeated enabled-category map construction during the per-rule loop
Preserved existing profile gating and rule matching behavior
Used existing policy tests to verify behavior did not change
Verification
go test ./internal/guard/policygo test ./internal/guard/judge -run TestStartLlamaServerHealthCheckAndStop -count=1 -vgo test ./internal/guard/judge -count=1go test ./...go vet ./...git diff --check